feat(Table): add EnableKeyboardNavigationCell parameter #6015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis pull request introduces a new EnableKeyboardNavigationCell parameter to the Table component, allowing developers to enable or disable keyboard navigation in Excel mode. The implementation updates the Table's Razor and JavaScript files to respect this parameter and adds a corresponding unit test. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
We encountered an error and are unable to review this PR. We have been notified and are working to fix it.
You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6015 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 670 670
Lines 30651 30653 +2
Branches 4362 4362
=========================================
+ Hits 30651 30653 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6014
Summary By Copilot
This pull request introduces a new feature to enable keyboard navigation in Excel mode for the
Tablecomponent in the BootstrapBlazor library. It includes updates to the component's Razor file, JavaScript file, and unit tests to support this functionality.Feature: Enable Keyboard Navigation in Excel Mode
Changes in Razor Component (
Table.razor.cs):EnableKeyboardNavigationCellwith a default value oftrueto control whether keyboard navigation is enabled in Excel mode.OnTableRenderAsyncmethod to pass theEnableKeyboardNavigationCellparameter to the table's configuration.Changes in JavaScript (
Table.razor.js):resetanddestroyTablefunctions to check theenableKeyboardNavigationCelloption before attaching or detaching keyboard event listeners, ensuring the behavior respects the new parameter. [1] [2]Unit Test Updates (
TableTest.cs):EnableKeyboardNavigationCellparameter can be set and functions correctly in Excel mode.These changes enhance the usability of the
Tablecomponent by allowing developers to enable or disable keyboard navigation in Excel mode as needed.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce a configurable parameter to enable or disable keyboard navigation in Excel mode for the Table component, updating component logic and tests accordingly.
New Features:
Enhancements:
Tests: